Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
authorssupport is limited to the CLI flags; consider extending the interactiveinitflow to allow entering multiple authors as well so the UX is consistent across modes. - In
Layout.__init__, bothauthorandauthorsare now accepted but only_authorsis stored; ifauthoris still part of the public API, it may be worth adding a short comment or TODO about its eventual deprecation to clarify the intended usage going forward.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `authors` support is limited to the CLI flags; consider extending the interactive `init` flow to allow entering multiple authors as well so the UX is consistent across modes.
- In `Layout.__init__`, both `author` and `authors` are now accepted but only `_authors` is stored; if `author` is still part of the public API, it may be worth adding a short comment or TODO about its eventual deprecation to clarify the intended usage going forward.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Related Documentation 1 document(s) may need updating based on files changed in this PR: Python Poetry cli
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #issue-number-here